[PATCH] gpu: host1x: Initialize firewall class to the jobs one
Mikko Perttunen
cyndis at kapsi.fi
Sun May 14 12:36:06 UTC 2017
Well spotted!
Reviewed-by: Mikko Perttunen <mperttunen at nvidia.com>
On 05/14/2017 12:01 AM, Dmitry Osipenko wrote:
> The commands stream is prepended by the jobs class on the CDMA submission,
> so that explicitly setting a module class in the commands stream isn't
> necessary. The firewall initializes its class to 0 and the command stream
> that doesn't explicitly specify the class effectively bypasses the firewall.
>
> Signed-off-by: Dmitry Osipenko <digetx at gmail.com>
> ---
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index 5f5f8ee6143d..d9933828fe87 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -504,7 +504,7 @@ static inline int copy_gathers(struct host1x_job *job, struct device *dev)
> fw.dev = dev;
> fw.reloc = job->relocarray;
> fw.num_relocs = job->num_relocs;
> - fw.class = 0;
> + fw.class = job->class;
>
> for (i = 0; i < job->num_gathers; i++) {
> struct host1x_job_gather *g = &job->gathers[i];
>
More information about the dri-devel
mailing list