[PATCH v7 0/5] replace hwmon_device_register for hwmon_device_register_with_info

[Oscar Salvador]

Hi Ben,

I'll fix the warnings.

Thanks for the time

Regards
Oscar Salvador

On 17 May 2017 at 01:06, Ben Skeggs <skeggsb at gmail.com> wrote:
> On 05/17/2017 07:18 AM, Oscar Salvador wrote:
>>
>> This v7 fixes removes dummy functions which only had a return and moves
>> the code
>> into the switch statements.
>
> Hey Oscar,
>
> I see new warnings with this series:
>
> /home/skeggsb/git/nouveau/drm/nouveau/nouveau_hwmon.c:645:8: warning:
> assignment discards ‘const’ qualifier from pointer target type
> [-Wdiscarded-qualifiers]
>    *buf = input_label;
>
> and
>
> /home/skeggsb/git/nouveau/drm/nouveau/nouveau_hwmon.c:200:18: warning:
> ‘pwm_fan_sensor_groups’ defined but not used [-Wunused-variable]
>
> The second one also warns for temp1_auto_point_sensor_groups too.
>
> Thanks,
> Ben.
>
>
>>
>> Versions:
>>
>> v1 -> v2:
>>          * Keep temp attrs as read only
>> v2 -> v3:
>>          * Code fix-ups: struct and string as const and add return within
>> switch
>>          due to fallthrough
>>          * Add Signed-off-by to all commits
>> v3 -> v4:
>>          * Rever const to struct attribute. Kbuild complains.
>> v4 -> v5:
>>          * Drops a check for attr_set in "nouveau_temp_is_visible".
>> v5 -> v6:
>>         * Change to nouveau/hwmon all commit titles
>>         * Drop author change
>>         * Coding-Style
>>         * Move the check before the switch in nouveau_power_is_visible
>> function
>>         * Expose temperature attrs as RW again
>>         * Get rid of nouveau_hwmon_set_pwm1/_enable and implement the code
>> inside
>>         nouveau_pwm_write
>>         * Get rid of nouveau_hwmon_set_temp_* and implement the code
>> inside
>>         nouveau_temp_write
>> v6 -> v7:
>>         * Got rid of all dummy functions that only had a return, and moved
>>         code into the switch statements.
>>
>>
>> This patchseries replaces the deprecated hwmon_device_register function
>> with the
>> new one hwmon_device_register_with_info.
>> It also does some cleanup.
>>
>> Oscar Salvador (5):
>>    nouveau/hwmon: Add config for all sensors and their settings
>>    nouveau/hwmon: Add nouveau_hwmon_ops structure with
>>      .is_visible/.read_string
>>    nouveau/hwmon: Remove old code, add .write/.read operations
>>    nouveau/hwmon: expose the auto_point and pwm_min/max attrs
>>    nouveau/hwmon: Change permissions to numeric
>>
>>   drivers/gpu/drm/nouveau/nouveau_hwmon.c | 979
>> +++++++++++++++-----------------
>>   1 file changed, 460 insertions(+), 519 deletions(-)
>>
>