[PATCH libdrm] xf86drm: fix compile error for declare i in for loop

Chih-Wei Huang cwhuang at android-x86.org
Wed May 17 18:02:51 UTC 2017


2017-05-18 0:10 GMT+08:00 Emil Velikov <emil.l.velikov at gmail.com>:
> On 17 May 2017 at 14:58, Yu, Qiang <Qiang.Yu at amd.com> wrote:
>> Hi Emil,
>>
>> I didn't modify the code. I'm using Ubuntu 14.04 gcc 4.8.4, the configure pass but
>> fail when compile.
>>
>> I think my gcc support c99 but needs adding "-std=c99" to enable it, and the configure
>> script add it into CC variable. When just use "make", it's OK, but my build script uses
>> "make CC=gcc".
>>
>> If you think current state is OK, I can change my build script for that.
>>
> Overrides shouldn't be used normally. If needed, one has to be very
> careful what they set them to.
>
> So the question is: why do you set CC - is there something broken on our end?
> Add "-std=c99" is fine, but I'd suggest dropping the override all together.

Indeed it also causes building error on Android
before and include 6.0.
Adding "-std=c99" will result in more strange errors
that I can't understand.
So I have to make a similar change to avoid it.


-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org


More information about the dri-devel mailing list