[PATCH libdrm] xf86drm: fix compile error for declare i in for loop

[Emil Velikov]

On 18 May 2017 at 14:46, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 18 May 2017 at 13:47, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>
>>> > Yes, I think you should change your build command. It's a shame that
>>> > autotools has this bug, but we'd like to avoid changing our codebase to
>>> > work around these, and in this case, it would mean dropping the C99
>>> > requirement and having to downgrade the whole codebase to something
>>> > older.
>>> >
>>> Again you're miles off, I'm afraid.
>>>
>>> Overrides is a make thing, which allows you to use [normally
>>> temporary] clever things.
>>> For example:
>>> - increase/decrease warning levels of part A in your project
>>> - change optimisation level of components B
>>
>> I have no issue with any of this, as long as flags are in $*FLAGS :)
>>
> AFAICT things such as -std=c99 belong to CC, since it implies the
> compiler itself.
> In a same way the "single-Unix-approved" /usr/bin/c99 does "exec gcc
> -std=c99 ${1+"$@"}"
>
Final note, hope it's not getting too tedious.

You really want to set the compiler/etc before configure stage.
Changing anything at make time can and will fail.
For example: a) configure adds -std=c99 to CFLAGS b) you change the
compiler to sunpro/etc (uses -xc99/-c99/etc) c) boom.

-Emil