[Nouveau] [RFC PATCH 0/3] drm/nouveau/dispnv04 overlay and primary fb format fixes

Ben Skeggs skeggsb at gmail.com
Sat May 20 05:47:44 UTC 2017


On 05/20/2017 12:57 PM, Ilia Mirkin wrote:
> This came out of some debugging I was doing to figure out how BE mode works
> on this hardware. Among other things, it came out that we're not exposing
> 16-bpp mode support and that the ARGB8888 mode that we do expose is broken.
> Also the overlay logic was pretty broken, I must have only tested with very
> "normal" overlay buffer sizes with modetest before.
> 
> That said, this code has only received literal testing on a NV34/G5 PPC combo.
> I was poking at various registers on a NV34/x86 to make modetest display the
> correct data though. That's where e.g. the pitch mask comes from.
> 
> I haven't at all tested on my NV05 or NV1x hardware. Should probably do that
> before we push this out. But since I've already been sitting on these patches
> for a few weeks, thought I'd get them out there.
The patches look fine to me, but I can wait to merge them until you've 
tested the older HW if you prefer.

Ben.

> 
> Ilia Mirkin (3):
>    drm/nouveau/overlay: improve error detection, fix pitch setting
>    drm/nouveau/overlay: add NV21 support
>    drm/nouveau/dispnv04: fix exposed format list
> 
>   drivers/gpu/drm/nouveau/dispnv04/crtc.c    | 36 +++++++++++-
>   drivers/gpu/drm/nouveau/dispnv04/overlay.c | 89 +++++++++++++++++++-----------
>   2 files changed, 93 insertions(+), 32 deletions(-)
> 


More information about the dri-devel mailing list