[PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback
Alexey Brodkin
Alexey.Brodkin at synopsys.com
Mon May 22 18:32:02 UTC 2017
Hi Jose,
The only nitpicking note from my side is patch name.
Probably full driver name as "arcpgu" might give a bit more context
especially if later something else from ARC appears in "drm" folder.
But IMHO that doesn't worth another respin.
On Fri, 2017-05-19 at 01:52 +0100, Jose Abreu wrote:
> Now that we have a callback to check if crtc supports a given mode
> we can use it in arcpgu so that we restrict the number of probbed
> modes to the ones we can actually display.
>
> This is specially useful because arcpgu crtc is responsible to set
> a clock value in the commit() stage but unfortunatelly this clock
> does not support all the needed ranges.
>
> Also, remove the atomic_check() callback as mode_valid() callback
> will be called before.
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
Reviewed-by: Alexey Brodkin <abrodkin at synopsys.com>
More information about the dri-devel
mailing list