[PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

Christian König deathsimple at vodafone.de
Tue May 23 07:43:32 UTC 2017


Am 23.05.2017 um 09:36 schrieb Daniel Vetter:
> On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote:
>> Am 23.05.2017 um 05:55 schrieb Michel Dänzer:
>>> On 23/05/17 12:50 PM, Lukas Wunner wrote:
>>>> On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote:
>>>>> On 22/05/17 11:04 PM, Lukas Wunner wrote:
>>>>>> On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote:
>>>>>>> On Thu, May 18 2017, Lukas Wunner wrote:
>>>>>> [snip]
>>>>>>>> Reported-by: Nicolai Stange <nicstange at gmail.com>
>>>>>>>> Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo")
>>>>>>>> Signed-off-by: Lukas Wunner <lukas at wunner.de>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> Awaiting a Tested-by: from Nicolai, but it's clear this is a bug and
>>>>>>>> needs to be fixed, so sending out with a proper commit message now.
>>>>>>>> The bug was only introduced to radeon, not amdgpu.
>>>>>>> Tested-by: Nicolai Stange <nicstange at gmail.com>
>>>>>>>
>>>>>>> Thanks for the quick fix!
>>>>>>>
>>>>>>>> @Alex Deucher: I could push this to drm-misc-fixes but then it wouldn't
>>>>>>>> land before -rc3 because Sean Paul has already sent out the -rc2 pull.
>>>>>>>> I notice you haven't sent out a pull for -rc2 yet, so maybe you want to
>>>>>>>> take it yourself?  Whichever you prefer.  Thanks & sorry for the breakage!
>>>>>> I've learned this morning that Alex is on vacation.
>>>>> Christian König is standing in for Alex.
>>>> By his own account, he already has "all hands full replacing him [Alex]",
>>>> explicitly asked Daniel to merge an amdgpu patch through drm-misc-next for
>>>> this reason and lacks permission to update branches in Alex' repo on fdo:
>>>>
>>>> "One lesson learned from the past week is that Alex needs to stop using
>>>> his personal repository on fdo.
>>>> We were asked a couple of times if I couldn't update a branch there from
>>>> different directions, which we obviously can't do."
>>>>
>>>> https://lists.freedesktop.org/archives/dri-devel/2017-May/142376.html
>>>> https://lists.freedesktop.org/archives/dri-devel/2017-May/142380.html
>>> The important point being that Christian reviewed that patch and
>>> explicitly asked Daniel to pick it up.
>> Wow, wait a second. I'm just catching up on this thread.
>>
>> Lukas didn't committed the patch to drm-misc without a review, didn't you?
>>
>> I was intentionally holding back a rb because that isn't my field of
>> expertise and I was only briefly involved in the original patch. Alex should
>> be back by the end of the week, so no need for a rush like that.
>>
>> Daniels patch was a global cleanup of include path done by search and
>> replace a complete different story.
> Want me to drop the patch until Alex is back? We're generally trying
> really hard to refrain from rebasing drm-misc branches, but for -fixes
> it's doable (since much less patch traffic there).

No, that would probably hurt more than it helps.

The patch is trivial and I just double checked the code and it should be 
fine.

Christian.



More information about the dri-devel mailing list