[PATCH 15/37] drm/arcgpu: Drop drm_vblank_cleanup
Alexey Brodkin
Alexey.Brodkin at synopsys.com
Wed May 24 14:57:09 UTC 2017
Hi Daniel,
On Wed, 2017-05-24 at 16:51 +0200, Daniel Vetter wrote:
> CRTC don't seem to get shut down in a controlled fashion, but no one
> bothers to stop interrupts either so this races no matter what. Might
> as well remove it. A call to drm_atomic_helper_shutdown would be
> pretty sweet somewhere (and maybe getting rid of the load/unload
> callbacks while at it).
>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
> drivers/gpu/drm/arc/arcpgu_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
> index 1926b200e4cb..3e43a5d4fb09 100644
> --- a/drivers/gpu/drm/arc/arcpgu_drv.c
> +++ b/drivers/gpu/drm/arc/arcpgu_drv.c
> @@ -155,7 +155,6 @@ static int arcpgu_unload(struct drm_device *drm)
> arcpgu->fbdev = NULL;
> }
> drm_kms_helper_poll_fini(drm);
> - drm_vblank_cleanup(drm);
> drm_mode_config_cleanup(drm);
>
> return 0;
Reviewed-by: Alexey Brodkin <abrodkin at synopsys.com>
More information about the dri-devel
mailing list