[PATCH libdrm] Android's major/minor/makedev live in <sys/sysmacros.h>

Rob Herring robh at kernel.org
Sun May 28 14:38:50 UTC 2017


On Mon, May 22, 2017 at 11:06 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 20 May 2017 at 19:24, enh <enh at google.com> wrote:
>> Bug: https://github.com/android-ndk/ndk/issues/398
>> ---
>>  Android.common.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Android.common.mk b/Android.common.mk
>> index 35c0f02c..b45ca10f 100644
>> --- a/Android.common.mk
>> +++ b/Android.common.mk
>> @@ -1,5 +1,6 @@
>>  # XXX: Consider moving these to config.h analogous to autoconf.
>>  LOCAL_CFLAGS += \
>> + -DMAJOR_IN_SYSMACROS=1 \
>>   -DHAVE_VISIBILITY=1 \
>>   -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>
>> --
> Thanks Elliott.
>
> Couple of tips for the future:
> Please set your name - $git config --global user.name "Elliott Hughes".
> If using git send-email is not possible, ensure that your client does
> not mangle with the patch.
>
> Rob, Mauro
> Gents can you check if this patch plays well on your setups. I don't
> want to break things on your end.

Definitely needed or AOSP master breaks. I've applied it (and a fix
because I forgot the trailing '\').

Rob


More information about the dri-devel mailing list