[PATCH v2] drm: Do not call drm_dev_unregister twice on drm_unplug_dev

Chris Wilson chris at chris-wilson.co.uk
Mon May 29 20:13:41 UTC 2017


On Mon, May 29, 2017 at 09:04:07PM +0200, Daniel Vetter wrote:
> On Mon, May 29, 2017 at 09:02:38PM +0200, Daniel Vetter wrote:
> > On Sun, May 28, 2017 at 07:16:55PM +0200, Hans de Goede wrote:
> > > Since commit a39be606f99d ("drm: Do a full device unregister when
> > > unplugging") drm_unplug_dev has been calling drm_dev_unregister followed
> > > by a drm_put_dev when open_count reaches 0. This drm_put_dev calls
> > > drm_dev_unregister again. Since drm_dev_unregister is not protected
> > > against being called multiple times this leads to havoc.
> > > 
> > > This commit fixes this by calling drm_dev_unref instead of drm_put_dev.
> > > 
> > > Fixes: a39be606f99d ("drm: Do a full device unregister when unplugging")
> > > Cc: Chris Wilson <chris at chris-wilson.co.uk>

> One more: When fixing a regression pls cc author/reviewer of the offending
> patch, for the learning. Adding Chris.

I was CC'ed, the ml stripping headers again?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list