[PATCH] drm/stm: checkpatch strict minor updates
Gustavo Padovan
gustavo at padovan.org
Wed Nov 1 11:33:01 UTC 2017
2017-10-26 Philippe Cornu <philippe.cornu at st.com>:
> Minor fixes detected with "scripts/checkpatch.pl --strict"
>
> Signed-off-by: Philippe Cornu <philippe.cornu at st.com>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++--
> drivers/gpu/drm/stm/ltdc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 10b2b77..3e8b9ed 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,
> int fvco_min, fvco_max, delta, best_delta; /* all in khz */
>
> /* Early checks preventing division by 0 & odd results */
> - if ((clkin_khz <= 0) || (clkout_khz <= 0))
> + if (clkin_khz <= 0 || clkout_khz <= 0)
> return -EINVAL;
>
> fvco_min = LANE_MIN_KBPS * 2 * ODF_MAX;
> @@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz,
> for (o = ODF_MIN; o <= ODF_MAX; o *= 2) {
> n = DIV_ROUND_CLOSEST(i * o * clkout_khz, clkin_khz);
> /* Check ndiv according to vco range */
> - if ((n < n_min) || (n > n_max))
> + if (n < n_min || n > n_max)
> continue;
> /* Check if new delta is better & saves parameters */
> delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) -
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 735c908..7be6710 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
> src_h = state->src_h >> 16;
>
> /* Reject scaling */
> - if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) {
> + if (src_w != state->crtc_w || src_h != state->crtc_h) {
> DRM_ERROR("Scaling is not supported");
> return -EINVAL;
Reviewed-by: Gustavo Padovan <gustavo.padovan at collabora.com>
More information about the dri-devel
mailing list