[PATCH 1/6] drm/probe-helper: Fix drm_kms_helper_poll_enable() docs

Daniel Vetter daniel at ffwll.ch
Mon Nov 6 08:45:35 UTC 2017


On Thu, Nov 02, 2017 at 09:09:04PM +0100, Noralf Trønnes wrote:
> Fix docs to reflect code and drm_kms_helper_poll_disable() docs by saying
> that calling drm_kms_helper_poll_enable() is fine even if output polling
> is not enabled.
> 
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  drivers/gpu/drm/drm_probe_helper.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> index 5840aabbf24e..024a89bf0ba7 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++ b/drivers/gpu/drm/drm_probe_helper.c
> @@ -216,8 +216,7 @@ enum drm_mode_status drm_connector_mode_valid(struct drm_connector *connector,
>   * suspend/resume.
>   *
>   * Drivers can call this helper from their device resume implementation. It is
> - * an error to call this when the output polling support has not yet been set
> - * up.
> + * not an error to call this even when output polling isn't enabled.
>   *
>   * Note that calls to enable and disable polling must be strictly ordered, which
>   * is automatically the case when they're only call from suspend/resume
> -- 
> 2.14.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list