video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init()

Dan Carpenter dan.carpenter at oracle.com
Mon Nov 6 09:53:45 UTC 2017


On Mon, Nov 06, 2017 at 10:00:25AM +0100, SF Markus Elfring wrote:
> >> If you want to lower the size of strings in this driver, you can do it,
> >> but not like this.
> > 
> > Just so we're clear, GCC already detects and combines it when you use
> > the same string constant twice.
> 
> Do you distinguish between merging of constants and the combination
> of statements for such an use case?

I would have rejected the patch even if GCC didn't combine the strings
because the most important thing is that the code is readable.

regards,
dan carpenter



More information about the dri-devel mailing list