[PATCH hwc] Android: add CleanSpec.mk

Rob Herring robh at kernel.org
Mon Nov 6 13:38:50 UTC 2017


On Mon, Nov 6, 2017 at 5:16 AM, Robert Foss <robert.foss at collabora.com> wrote:
> Hey Rob,
>
> On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote:
>> On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang <cwhuang at android-x86.
>> org> wrote:
>> > The file contains rules that are executed on incremental builds.
>> > Since commit 4f7dc9b6 the library was moved to /vendor so
>> > the old file must be removed.
>> >
>> > Signed-off-by: Chih-Wei Huang <cwhuang at linux.org.tw>
>> > ---
>> >  CleanSpec.mk | 1 +
>> >  1 file changed, 1 insertion(+)
>> >  create mode 100644 CleanSpec.mk
>> >
>> > diff --git a/CleanSpec.mk b/CleanSpec.mk
>> > new file mode 100644
>> > index 0000000..99dcecd
>> > --- /dev/null
>> > +++ b/CleanSpec.mk
>> > @@ -0,0 +1 @@
>> > +$(call add-clean-step, rm -rf
>> > $(TARGET_OUT)/lib*/hw/hwcomposer.drm.so)
>>
>> Seems a bit silly to add forever an explicit file to clean for a
>> transient problem.
>>
> While transient, if maintaining multuple Android versions it may still
> stick around for quite some time.

That's not the issue. Once you do a clean build, the problem is gone
regardless of version.

Rob


More information about the dri-devel mailing list