[PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings

Sumit Semwal sumit.semwal at linaro.org
Tue Nov 7 08:07:10 UTC 2017


Hi Ville,

On 3 November 2017 at 13:18, Christian König <christian.koenig at amd.com> wrote:
> Patch #4 is Reviewed-by: Christian König <christian.koenig at amd.com>.
>
> The rest is Acked-by: Christian König <christian.koenig at amd.com>.
>
> Regards,
> Christian.
>
>
> Am 02.11.2017 um 21:03 schrieb Ville Syrjala:
>>
>> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>
>> When building drm+i915 I get around 150 lines of sparse noise from
>> dma_fence __rcu warnings. This series eliminates all of that.
>>
>> The first two patches were already posted by Chris, but there wasn't
>> any real reaction, so I figured I'd repost with a wider Cc list.
>>
>> As for the other two patches, I'm no expert on dma_fence and I didn't
>> spend a lot of time looking at it so I can't be sure I annotated all
>> the accesses correctly. But I figured someone will scream at me if
>> I got it wrong ;)
>>
>> Cc: Dave Airlie <airlied at redhat.com>
>> Cc: Jason Ekstrand <jason at jlekstrand.net>
>> Cc: linaro-mm-sig at lists.linaro.org
>> Cc: linux-media at vger.kernel.org
>> Cc: Alex Deucher <alexander.deucher at amd.com>
>> Cc: Christian König <christian.koenig at amd.com>
>> Cc: Sumit Semwal <sumit.semwal at linaro.org>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>>
>> Chris Wilson (2):
>>    drm/syncobj: Mark up the fence as an RCU protected pointer
>>    dma-buf/fence: Sparse wants __rcu on the object itself
>>
>> Ville Syrjälä (2):
>>    drm/syncobj: Use proper methods for accessing rcu protected pointers
>>    dma-buf: Use rcu_assign_pointer() to set rcu protected pointers

For patches 2 (with Daniel's minor comment) and 4, please feel free to add my
Acked-by: Sumit Semwal <sumit.semwal at linaro.org.

>>
>>   drivers/dma-buf/reservation.c |  2 +-
>>   drivers/gpu/drm/drm_syncobj.c | 11 +++++++----
>>   include/drm/drm_syncobj.h     |  2 +-
>>   include/linux/dma-fence.h     |  2 +-
>>   4 files changed, 10 insertions(+), 7 deletions(-)
>>
>

Best,
Sumit.


More information about the dri-devel mailing list