[PATCH] drm/ttm: set bo->resv point to tbo->ttm_resv after individualize_resv

Michel Dänzer michel at daenzer.net
Tue Nov 7 16:16:00 UTC 2017


On 07/11/17 02:44 PM, Christian König wrote:
> Set bo->resv to ttm_resv during BO cleanup. This way freed BOs can be
> better reaped during eviction.
> 
> Signed-off-by: Roger He <Hongbo.He at amd.com>
> Signed-off-by: Christian König <christian.koenig at amd.com>

KASAN caught some badness while running piglit with this applied, see
the attached dmesg excerpts.


At least some of this might be pre-existing bugs being exposed by this
change. E.g. I've been chasing another use-after-free, with
ttm_bo_delayed_delete trying to reserve a BO which has already been
destroyed. Looks like maybe the ddestroy list handling isn't quite
watertight yet.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kern.log
Type: text/x-log
Size: 49868 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171107/7ebfba37/attachment-0001.bin>


More information about the dri-devel mailing list