drivers/gpu/drm/bridge/lvds-encoder.c broken in mainline

Eric Anholt eric at anholt.net
Wed Nov 8 18:18:03 UTC 2017


Lothar Waßmann <LW at KARO-electronics.de> writes:

> Hi,
>
> drivers/gpu/drm/bridge/lvds-encoder.c driver is currently
> dysfunctional due to:
> |commit 13dfc0540a575b47b2d640b093ac16e9e09474f6
> |Author: Eric Anholt <eric at anholt.net>
> |Date:   Fri Jun 2 13:25:14 2017 -0700
> |
> |    drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.
>
> Also, there is no in-kernel user of this driver, so that it obviously
> doesn't get tested in any way. There is only one dts file (r8a7779-marzen.dts)
> that instantiates this driver, but it has an incomplete OF graph. The missing
> link for the OF graph is provided by either r8a77xx-aa104xd12-panel.dtsi or
> r8a77xx-aa121td01-panel.dtsi, but those files are referenced nowhere in
> the kernel source.
>
> Should the driver be removed or moved to staging, until it is properly
> fixed?

I can't see any behavior change about the DT handling in that commit,
and I didn't intend for there to be any.  Could you help me understand
what went wrong?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171108/579c0549/attachment.sig>


More information about the dri-devel mailing list