[PATCH] drm/vgem: Fix vgem_init to get drm device avaliable.

[Sharma, Deepak]

-----Original Message-----
From: Emil Velikov [mailto:emil.l.velikov at gmail.com] 
Sent: Monday, October 30, 2017 6:23 AM
To: Sharma, Deepak <Deepak.Sharma at amd.com>
Cc: ML dri-devel <dri-devel at lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Stéphane Marchesin <marcheu at chromium.org>
Subject: Re: [PATCH] drm/vgem: Fix vgem_init to get drm device avaliable.

On 26 October 2017 at 00:02, Deepak Sharma <Deepak.Sharma at amd.com> wrote:
> From: Deepak Sharma <deepak.sharma at amd.com>
>
> Modify vgem_init to take platform dev as parent in drm_dev_init.
> This will make drm device available at "/sys/devices/platform/vgem"
> in x86 chromebook.
>
Shouldn't one update the drm_dev_init/drm_dev_alloc documentation while doing this?
But more importantly, this will change the "unique" string (see drm_dev_set_unique).

Sorry I did not get your comment about updating drm_dev_init/drm_dev_alloc documentation 
for this change. Do you see any issue if this "unique string " is changed

The topic around it rather convoluted and messy, so please check this change doesn't cause subtle regressions.
There's a doc hunk in drm_ioctl.c to begin with, plus userspace such as IGT [1] might rely on the current behaviour.

HTH
Emil

[1] https://cgit.freedesktop.org/drm/igt-gpu-tools/

I did run vgem test from IGT to check for regression , do you suspect regression in other tests ?

Thanks,
Deepak