[PATCH] drm/gem-cma-helper: Change the level of the allocation failure message
Eric Anholt
eric at anholt.net
Wed Oct 4 22:28:54 UTC 2017
Boris Brezillon <boris.brezillon at free-electrons.com> writes:
> drm_gem_cma_create() prints an error message when dma_alloc_wc() fails to
> allocate the amount of memory we requested. This can lead to annoying
> error messages when CMA is only one possible source of memory for the BO
> allocation.
>
> Turn this error message into a debug one and add a __must_check specifier
> to make sure all callers are checking the return value.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
The __must_check seems unnecessary to me -- you're definitely going to
be doing something with the return value, because otherwise why did you
call the object allocate function?
That said, thanks for cleaning up the error message.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171004/d77069d9/attachment.sig>
More information about the dri-devel
mailing list