[PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

[Archit Taneja]

On 10/11/2017 02:56 PM, Boris Brezillon wrote:
> Hi Archit,
> 
> On Thu, 7 Sep 2017 15:06:13 +0530
> Archit Taneja <architt at codeaurora.org> wrote:
> 
>>
>>> +
>>> +static void cdns_dsi_bridge_disable(struct drm_bridge *bridge)
>>> +{
>>> +	struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
>>> +	struct cdns_dsi *dsi = input_to_dsi(input);
>>> +	u32 val;
>>> +
>>> +	val = readl(dsi->regs + MCTL_MAIN_DATA_CTL);
>>> +	val &= ~(IF_VID_SELECT_MASK | IF_VID_MODE | VID_EN | HOST_EOT_GEN |
>>> +		 DISP_EOT_GEN);
>>
>> I see some truncation related sparse warnings here and a couple of other places
>> when building against arm32. Those would be nice to fix.
> 
> I had a look and it seems to happen everytime I use GENMASK() (the
> truncation is harmless, but sparse complains).
> If you don't mind, I'd prefer to keep GENMASK() rather than manually
> defining masks, but maybe you have an idea how to fix these warnings
> without getting rid of GENMASK().

I don't know either. Let's live with the warnings for now.

Thanks,
Archit

> 
>>
>>> +	writel(val, dsi->regs + MCTL_MAIN_DATA_CTL);
>>> +
>>> +	val = readl(dsi->regs + MCTL_MAIN_EN) & ~IF_EN(input->id);
>>> +	writel(val, dsi->regs + MCTL_MAIN_EN);
>>> +}
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project