[PATCH] drm: Add DPMS ioctl

Alex Ivanov gnidorah at ya.ru
Wed Oct 11 10:58:13 UTC 2017



On 11.10.2017 12:04, Daniel Vetter wrote:
>
> Why exactly is the existing dpms ioctl not good enough? it's implemented
> as the "DPMS" property attached to connectors, but that's the only
> difference compared to your code here.
>
> Also, that one doesn't have any XXX about atomic like yours.
>
> I also have no idea how this fixes any of your above problems.
> -Daniel
It's not good enough because it will only succeed if caller is current
DRM master. Which means it will work only in console, since X.Org
and Wayland hold DRM_MASTER.

But as a security measure this new separate ioctl requires calling
process to be root one.

I will fix XXX atomic in second version of this patch, it's pretty
mechanical change. Current stage is to get acceptance by public.


More information about the dri-devel mailing list