[PATCH] video: fbdev: make fb_var_screeninfo static, const and __initconst
Bartlomiej Zolnierkiewicz
b.zolnierkie at samsung.com
Thu Oct 12 16:06:46 UTC 2017
[ added dri-devel & sparclinux MLs to cc: ]
On Thursday, September 14, 2017 06:02:14 PM Bhumika Goyal wrote:
> Make these structures static as they are not referenced in any other
> file. Make them const as they are used only during a copy operation.
> Replace __initdata with __initconst in file igafb.c to avoid section
> conflict error.
>
> Signed-off-by: Bhumika Goyal <bhumirks at gmail.com>
> ---
> The changes are not compile tested as I could not find the right
> architecture to cross compile the files.
>
> drivers/video/fbdev/dnfb.c | 2 +-
> drivers/video/fbdev/igafb.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
You can deduce such things by looking into Makefile-s and KConfig-s:
- dnfb is used by apollo platform of m68k arch
- igafb can be used on sparc32 arch
I took care of compile testing these changes and discovered that
in the current vanilla kernel (v4.14-rc4) igafb fails to build.
Thus I've only queued dnfb changes for v4.15 kernel for now.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
More information about the dri-devel
mailing list