[PATCH v11 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

kbuild test robot lkp at intel.com
Thu Oct 12 22:44:28 UTC 2017


Hi Meghana,

[auto build test WARNING on v4.14-rc3]
[also build test WARNING on next-20171009]
[cannot apply to drm/drm-next backlight/for-backlight-next drm-exynos/exynos-drm/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Meghana-Madhyastha/Move-backlight-helper-functions-from-tinydrm-helpers-to-linux-backlight/20171013-062032
config: i386-randconfig-x001-201741 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/video/backlight/backlight.c: In function 'backlight_get':
>> drivers/video/backlight/backlight.c:609:39: warning: character constant too long for its type
      np = of_parse_phandle(dev->of_node, 'backlight', 0);
                                          ^~~~~~~~~~~
>> drivers/video/backlight/backlight.c:609:39: warning: passing argument 2 of 'of_parse_phandle' makes pointer from integer without a cast [-Wint-conversion]
   In file included from include/linux/irqdomain.h:34:0,
                    from include/linux/i2c.h:34,
                    from include/uapi/linux/fb.h:5,
                    from include/linux/fb.h:5,
                    from include/linux/backlight.h:12,
                    from drivers/video/backlight/backlight.c:13:
   include/linux/of.h:358:28: note: expected 'const char *' but argument is of type 'int'
    extern struct device_node *of_parse_phandle(const struct device_node *np,
                               ^~~~~~~~~~~~~~~~

vim +609 drivers/video/backlight/backlight.c

   582	
   583	/**
   584	 * backlight_get - Get backlight device
   585	 * @dev: Device
   586	 *
   587	 * This function looks for a property named 'backlight' on the DT node
   588	 * connected to @dev and looks up the backlight device.
   589	 *
   590	 * Call backlight_put() to drop the reference on the backlight device.
   591	 *
   592	 * Returns:
   593	 * A pointer to the backlight device if found.
   594	 * Error pointer -EPROBE_DEFER if the DT property is set, but no backlight
   595	 * device is found.
   596	 * NULL if there's no backlight property.
   597	 */
   598	
   599	#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
   600	struct backlight_device *backlight_get(struct device *dev)
   601	{
   602		struct backlight_device *bd = NULL;
   603		struct device_node *np;
   604	
   605		if (!dev)
   606			return NULL;
   607	
   608		if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
 > 609			np = of_parse_phandle(dev->of_node, 'backlight', 0);
   610			if (np) {
   611				bd = of_find_backlight_by_node(np);
   612				of_node_put(np);
   613				if (!bd)
   614					return ERR_PTR(-EPROBE_DEFER);
   615			}
   616		}
   617	
   618		return bd;
   619	}
   620	EXPORT_SYMBOL(backlight_get);
   621	#endif
   622	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 27129 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171013/85c70510/attachment-0001.gz>


More information about the dri-devel mailing list