[radeon-alex:amd-staging-drm-next 120/173] drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c:2943:5-35: duplicated argument to && or || (fwd)

Julia Lawall julia.lawall at lip6.fr
Fri Oct 13 07:01:05 UTC 2017


Hello,

There are two checks for dm_444_16on line 2943.

julia

---------- Forwarded message ----------
Date: Fri, 13 Oct 2017 08:24:34 +0800
From: kbuild test robot <fengguang.wu at intel.com>
To: kbuild at 01.org
Cc: Julia Lawall <julia.lawall at lip6.fr>
Subject: [radeon-alex:amd-staging-drm-next 120/173]
    drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c:2943:5-35:
    duplicated argument to && or ||

CC: kbuild-all at 01.org
CC: dri-devel at lists.freedesktop.org
CC: Harry Wentland <harry.wentland at amd.com>
CC: Tony Cheng <Tony.Cheng at amd.com>

tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   1b006d838f78d7822f606087fa12ea7ad2c5753b
commit: 3cc51acd2adc70b6ad7dc325ff87e8a253e764d3 [120/173] drm/amd/display: Restructuring and cleaning up DML
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

>> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c:2943:5-35: duplicated argument to && or ||

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout 3cc51acd2adc70b6ad7dc325ff87e8a253e764d3
vim +2943 drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c

3cc51acd Dmytro Laktyushkin 2017-08-23  2932
3cc51acd Dmytro Laktyushkin 2017-08-23  2933  bool Calculate256BBlockSizes(enum source_format_class SourcePixelFormat,
3cc51acd Dmytro Laktyushkin 2017-08-23  2934  	enum dm_swizzle_mode SurfaceTiling,
3cc51acd Dmytro Laktyushkin 2017-08-23  2935  	unsigned int BytePerPixelY,
3cc51acd Dmytro Laktyushkin 2017-08-23  2936  	unsigned int BytePerPixelC,
3cc51acd Dmytro Laktyushkin 2017-08-23  2937  	unsigned int *BlockHeight256BytesY,
3cc51acd Dmytro Laktyushkin 2017-08-23  2938  	unsigned int *BlockHeight256BytesC,
3cc51acd Dmytro Laktyushkin 2017-08-23  2939  	unsigned int *BlockWidth256BytesY,
3cc51acd Dmytro Laktyushkin 2017-08-23  2940  	unsigned int *BlockWidth256BytesC)
3cc51acd Dmytro Laktyushkin 2017-08-23  2941  {
3cc51acd Dmytro Laktyushkin 2017-08-23  2942  	if ((SourcePixelFormat == dm_444_64 || SourcePixelFormat == dm_444_32
3cc51acd Dmytro Laktyushkin 2017-08-23 @2943  		|| SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16
3cc51acd Dmytro Laktyushkin 2017-08-23  2944  		|| SourcePixelFormat == dm_444_8)) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2945  		if (SurfaceTiling == dm_sw_linear) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2946  			*BlockHeight256BytesY = 1;
3cc51acd Dmytro Laktyushkin 2017-08-23  2947  		} else if (SourcePixelFormat == dm_444_64) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2948  			*BlockHeight256BytesY = 4;
3cc51acd Dmytro Laktyushkin 2017-08-23  2949  		} else if (SourcePixelFormat == dm_444_8) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2950  			*BlockHeight256BytesY = 16;
3cc51acd Dmytro Laktyushkin 2017-08-23  2951  		} else {
3cc51acd Dmytro Laktyushkin 2017-08-23  2952  			*BlockHeight256BytesY = 8;
3cc51acd Dmytro Laktyushkin 2017-08-23  2953  		}
3cc51acd Dmytro Laktyushkin 2017-08-23  2954  		*BlockWidth256BytesY = 256 / BytePerPixelY / *BlockHeight256BytesY;
3cc51acd Dmytro Laktyushkin 2017-08-23  2955  		*BlockHeight256BytesC = 0;
3cc51acd Dmytro Laktyushkin 2017-08-23  2956  		*BlockWidth256BytesC = 0;
3cc51acd Dmytro Laktyushkin 2017-08-23  2957  	} else {
3cc51acd Dmytro Laktyushkin 2017-08-23  2958  		if (SurfaceTiling == dm_sw_linear) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2959  			*BlockHeight256BytesY = 1;
3cc51acd Dmytro Laktyushkin 2017-08-23  2960  			*BlockHeight256BytesC = 1;
3cc51acd Dmytro Laktyushkin 2017-08-23  2961  		} else if (SourcePixelFormat == dm_420_8) {
3cc51acd Dmytro Laktyushkin 2017-08-23  2962  			*BlockHeight256BytesY = 16;
3cc51acd Dmytro Laktyushkin 2017-08-23  2963  			*BlockHeight256BytesC = 8;
3cc51acd Dmytro Laktyushkin 2017-08-23  2964  		} else {
3cc51acd Dmytro Laktyushkin 2017-08-23  2965  			*BlockHeight256BytesY = 8;
3cc51acd Dmytro Laktyushkin 2017-08-23  2966  			*BlockHeight256BytesC = 8;
3cc51acd Dmytro Laktyushkin 2017-08-23  2967  		}
3cc51acd Dmytro Laktyushkin 2017-08-23  2968  		*BlockWidth256BytesY = 256 / BytePerPixelY / *BlockHeight256BytesY;
3cc51acd Dmytro Laktyushkin 2017-08-23  2969  		*BlockWidth256BytesC = 256 / BytePerPixelC / *BlockHeight256BytesC;
3cc51acd Dmytro Laktyushkin 2017-08-23  2970  	}
3cc51acd Dmytro Laktyushkin 2017-08-23  2971  	return true;
3cc51acd Dmytro Laktyushkin 2017-08-23  2972  }
3cc51acd Dmytro Laktyushkin 2017-08-23  2973

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


More information about the dri-devel mailing list