[PATCH 2/4] drm: Add missing __user annotation to drm_syncobj_array_find()

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Oct 13 13:08:26 UTC 2017


On Fri, Sep 01, 2017 at 07:44:46PM +0200, Thierry Reding wrote:
> On Fri, Sep 01, 2017 at 07:53:26PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > 'user_handles' needs a __user annotation for fix the following sparse
> > warning:
> > drm_syncobj.c:813:37: warning: incorrect type in argument 2 (different address spaces)
> > drm_syncobj.c:813:37:    expected void const [noderef] <asn:1>*from
> > drm_syncobj.c:813:37:    got void *user_handles
> > drm_syncobj.c:875:38: warning: incorrect type in argument 2 (different address spaces)
> > drm_syncobj.c:875:38:    expected void *user_handles
> > drm_syncobj.c:875:38:    got void [noderef] <asn:1>*<noident>
> > drm_syncobj.c:908:38: warning: incorrect type in argument 2 (different address spaces)
> > drm_syncobj.c:908:38:    expected void *user_handles
> > drm_syncobj.c:908:38:    got void [noderef] <asn:1>*<noident>
> > drm_syncobj.c:941:38: warning: incorrect type in argument 2 (different address spaces)
> > drm_syncobj.c:941:38:    expected void *user_handles
> > drm_syncobj.c:941:38:    got void [noderef] <asn:1>*<noident>
> > 
> > Cc: Jason Ekstrand <jason at jlekstrand.net>
> > Fixes: 3e6fb72d6cef ("drm/syncobj: Add a syncobj_array_find helper")
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/drm_syncobj.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Thierry Reding <treding at nvidia.com>

Pushed the remainder of this series to drm-misc-next. Thanks for the review.

-- 
Ville Syrjälä
Intel OTC


More information about the dri-devel mailing list