[PATCH v13 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

[Daniel Vetter]

Hi Meghana,

On Fri, Oct 13, 2017 at 04:09:27PM +0530, Meghana Madhyastha wrote:
> Move drm helper functions from tinydrm-helpers to linux/backlight for
> ease of use by callers in other drivers.

I've been a bit overloaded past few days, so didn't get around to looking
at any of your patches yet, but just a quick suggestion on process: Please
don't resend complicated patches this quickly. It takes various reviewers
a while to grasp the latest updates and complications, often they first
need to find a bit of time to really think things through. So if you
resend multiple times per day it gets overwhelming and confusing for
reviewers. E.g. on your work here I think about 4 different people
comment, but all in different threads, so harder to get towards some
consensus.

Your enthusiasm and drive is great here, but please keep in mind that the
people reviewing your patches do this more or less in their spare time
(Sean&me blocked some time for outreachy, but can't go through it all
every day).

I think Sean volunteered to take a detailed look at your series, pls ping
him on irc to coordinate patch reworks (if that's still needed).

Thanks, Daniel

> Changes in v13:
> -Rebase against drm-misc
> -Put devm_backlight_put back
> 
> Meghana Madhyastha (3):
>   drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h
>   drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c
>   drm/tinydrm: Add devres versions of backlight_get
> 
>  drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 95 --------------------------
>  drivers/gpu/drm/tinydrm/mi0283qt.c             |  3 +-
>  drivers/gpu/drm/tinydrm/mipi-dbi.c             |  5 +-
>  drivers/video/backlight/backlight.c            | 68 ++++++++++++++++++
>  include/drm/tinydrm/tinydrm-helpers.h          |  4 --
>  include/linux/backlight.h                      | 55 +++++++++++++++
>  6 files changed, 128 insertions(+), 102 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch