[PATCH v2 2/2] vgaarb: Factor out EFI and fallback default device selection

Daniel Axtens dja at axtens.net
Wed Oct 18 11:05:57 UTC 2017


Daniel Vetter <daniel at ffwll.ch> writes:

> On Wed, Oct 18, 2017 at 11:24:43AM +1100, Daniel Axtens wrote:
>> Hi Daniel,
>> 
>> >> Initially I wondered if this info printk could be moved into
>> >> vga_arbiter_check_bridge_sharing(), but it's been separated out since
>> >> 3448a19da479b ("vgaarb: use bridges to control VGA routing where
>> >> possible."), and upon closer examination, it seems you can't be sure a
>> >> device doesn't share a bridge until the end of the process, so this is
>> >> indeed correct.
>> >> 
>> >> Everything else also looks good to me.
>> >> 
>> >> Reviewed-by: Daniel Axtens <dja at axtens.net>
>> >
>> > R-b for both patches? And ok with everyone if I pull this into drm-misc
>> > for 4.15 (deadline is end of this week for feature-y stuff)?
>> 
>> I had only intended it for patch 2, but I've now read over patch 1 to my
>> satisfaction, so it too is:
>> 
>> Reviewed-by: Daniel Axtens <dja at axtens.net>
>
> Both applied for 4.15, thanks.

Cool - thanks!

A special thanks to Bjorn for persisting with this and coming up with a
nice simple solution :)

Regards,
Daniel

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch


More information about the dri-devel mailing list