[PATCH] drm/dp: Update SET_POWER_MASK to include the D3 Aux-On state too.

Dhinakaran Pandiyan dhinakaran.pandiyan at intel.com
Mon Oct 30 22:21:56 UTC 2017


Updating the mask is needed to clear all the three power state bits before
setting the required power state. Also add a comment documenting that
D3 Aux-On state has been available DPCD v1.2 onwards. Thanks to Ville for
pointing this out.

Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Jani Nikula <jani.nikula at intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
---
 include/drm/drm_dp_helper.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 9049ef133d69..aea10f85dd4c 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -617,8 +617,8 @@
 #define DP_SET_POWER                        0x600
 # define DP_SET_POWER_D0                    0x1
 # define DP_SET_POWER_D3                    0x2
-# define DP_SET_POWER_MASK                  0x3
-# define DP_SET_POWER_D3_AUX_ON             0x5
+# define DP_SET_POWER_D3_AUX_ON             0x5      /* DPCD >= 1.2 */
+# define DP_SET_POWER_MASK                  0x7
 
 #define DP_EDP_DPCD_REV			    0x700    /* eDP 1.2 */
 # define DP_EDP_11			    0x00
-- 
2.11.0



More information about the dri-devel mailing list