[PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check

Russell King - ARM Linux linux at armlinux.org.uk
Tue Oct 31 17:03:43 UTC 2017


On Tue, Oct 31, 2017 at 04:21:42PM +0200, Andy Shevchenko wrote:
> Since i2c_unregister_device() became NULL-aware we may remove duplicate
> NULL check.
> 
> Cc: Russell King <linux at armlinux.org.uk>

Acked-by: Russell King <rmk+kernel at armlinux.org.uk>

Thanks.

> Cc: David Airlie <airlied at linux.ie>
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index 4d1f45acf2cd..7a349e85f964 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1602,8 +1602,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
>  	/* if encoder_init fails, the encoder slave is never registered,
>  	 * so cleanup here:
>  	 */
> -	if (priv->cec)
> -		i2c_unregister_device(priv->cec);
> +	i2c_unregister_device(priv->cec);
>  	return -ENXIO;
>  }
>  
> -- 
> 2.14.2
> 

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up


More information about the dri-devel mailing list