[PATCH v3 17/22] drm/stm: Use drm_gem_fb_create()

[Daniel Vetter]

On Sat, Sep 02, 2017 at 02:45:36PM +0200, Noralf Trønnes wrote:
> 
> Den 01.09.2017 13.28, skrev Philippe CORNU:
> > Hi Noralf,
> > Many thanks for your patchset (and sorry for this late reply due to
> > summer holidays :-),
> > 
> > On 08/13/2017 03:32 PM, Noralf Trønnes wrote:
> > > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now,
> > > so use the function directly.
> > > 
> > > Cc: Yannick Fertre <yannick.fertre at st.com>
> > > Cc: Philippe Cornu <philippe.cornu at st.com>
> > > Cc: Benjamin Gaignard <benjamin.gaignard at linaro.org>
> > > Cc: Vincent Abriou <vincent.abriou at st.com>
> > > Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> > Acked-by: Philippe Cornu <philippe.cornu at st.com>
> > Tested-by: Philippe Cornu <philippe.cornu at st.com>
> 
> Thanks for your testing Philippe, it's appreciated.
> It's reassuring to see that someone else gets this to work as well :-)
> Applied to drm-misc.

btw for testing, as long as it touches i915.ko, just cc the entire patch
series (not just individual patches) to the intel-gfx mailing list, and
our CI will crunch it for you. Atm that's about 15h of machine time we
throw at each patch series.
-Daniel

> 
> Noralf.
> 
> > Philippe :-)
> > 
> > > ---
> > >    drivers/gpu/drm/stm/drv.c | 3 ++-
> > >    1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
> > > index b333b37..c857663 100644
> > > --- a/drivers/gpu/drm/stm/drv.c
> > > +++ b/drivers/gpu/drm/stm/drv.c
> > > @@ -17,6 +17,7 @@
> > >    #include <drm/drm_crtc_helper.h>
> > >    #include <drm/drm_fb_cma_helper.h>
> > >    #include <drm/drm_gem_cma_helper.h>
> > > +#include <drm/drm_gem_framebuffer_helper.h>
> > >    #include "ltdc.h"
> > > @@ -31,7 +32,7 @@ static void drv_output_poll_changed(struct drm_device *ddev)
> > >    }
> > >    static const struct drm_mode_config_funcs drv_mode_config_funcs = {
> > > -	.fb_create = drm_fb_cma_create,
> > > +	.fb_create = drm_gem_fb_create,
> > >    	.output_poll_changed = drv_output_poll_changed,
> > >    	.atomic_check = drm_atomic_helper_check,
> > >    	.atomic_commit = drm_atomic_helper_commit,
> > > 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch