[PATCH v2] drm/tve200: Replace custom connector with panel bridge

[Daniel Vetter]

On Mon, Sep 04, 2017 at 10:14:42AM +0200, Linus Walleij wrote:
> On Mon, Sep 4, 2017 at 9:52 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Sat, Sep 02, 2017 at 10:07:11PM +0200, Linus Walleij wrote:
> >> This replaces the custom connector in the TVE200 with the
> >> panel bridge helper. As long as we're just using panels
> >> and no other bridges, this works just fine.
> >>
> >> Reviewed-by: Eric Anholt <eric at anholt.net>
> >> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> >> ---
> >> ChangeLog v1->v2:
> >> - Drop a few surplus #includes
> >> - Collect Eric's review tag
> 
> >> +     /* We need the encoder to attach the bridge */
> >> +     priv->encoder = &priv->pipe.encoder;
> >
> > drm_simple_display_pipe_attach_bridge(). Fairly new addition, would be
> > great if you can also fix up wherever you copy-pasted this from :-)
> 
> The horrible truth is that I did not copy-paste it, I came up with
> this for PL111 but using a v4.13 tree and then forward-patching
> on top of drm-next.

drm moves fast, developing on anything older than drm-tip/linux-next
considered harmful :-)

I know that this is a problem for many arm-soc boards where lots of stuff
isn't in upstream, but that's not really something we can fix in drm.

> > I didn't check all the details, but lgtm otherwise. With this nit
> > addressed:
> >
> > Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Gnah I already pushed it after Eric's review, but I can make
> a follow-up patch, I will also try to get it right in PL111.

nw, I'll look at those patches as soon as the fly by.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch