[PATCH 05/12] drm/cirrus: hardcode vram size

Gerd Hoffmann kraxel at redhat.com
Mon Sep 11 08:31:03 UTC 2017


On Fri, 2017-09-08 at 19:05 +0530, Varad Gautam wrote:
> From: Zach Reizner <zachr at google.com>
> 
> There is no reliable way of detecting actual VRAM size, which is
> important in the case of cirrus because cursor data is always stored
> in
> the last 16K of VRAM. Because qemu effectivaly hardcodes 4MB but
> reports
> 32MB, we hardcode 4MB in the cirrus driver to ensure the cursor works
> properly.

This comment is misleading.  pci bar size != vram size.  There is more
stuff in the pci bar than just the vram, thats why it is larger than
vram.  It's not qemu mis-reporting something.

The actual vram size is 4MB.  This is what the original hardware had,
so the qemu emulation uses that too.  So the fix is correct, but please
adjust commit message and comment.

cheers,
  Gerd




More information about the dri-devel mailing list