[PATCH 2/2] drm: Don't export the drm_gem_dumb_destroy() function

[Noralf Trønnes]

Den 15.09.2017 04.27, skrev Laurent Pinchart:
> The drm_gem_dumb_destroy() isn't used in drivers, don't export it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> ---
>   drivers/gpu/drm/drm_dumb_buffers.c | 7 ++++---
>   drivers/gpu/drm/drm_gem.c          | 1 -
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
> index 39ac15ce4702..7abf6fd6b52f 100644
> --- a/drivers/gpu/drm/drm_dumb_buffers.c
> +++ b/drivers/gpu/drm/drm_dumb_buffers.c
> @@ -44,9 +44,10 @@
>    * KMS frame buffers.
>    *
>    * To support dumb objects drivers must implement the &drm_driver.dumb_create
> - * operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy() if
> - * not set and &drm_driver.dumb_map_offset defaults to
> - * drm_gem_dumb_map_offset(). See the callbacks for further details.
> + * and &drm_driver.dumb_map_offset operations (the latter defaults to
> + * drm_gem_dumb_map_offset() if not set). Drivers that don't use GEM handles
> + * additionally need to implement the &drm_driver.dumb_destroy operation. See
> + * the callbacks for further details.
>    *
>    * Note that dumb objects may not be used for gpu acceleration, as has been
>    * attempted on some ARM embedded platforms. Such drivers really must have
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index ad4e9cfe48a2..6b23b707b15f 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -360,7 +360,6 @@ int drm_gem_dumb_destroy(struct drm_file *file,

Maybe drop the docs as well since no one will use it and afaict it's
not linked from anywhere after this patch.

>   {
>   	return drm_gem_handle_delete(file, handle);
>   }
> -EXPORT_SYMBOL(drm_gem_dumb_destroy);
>   

Shouldn't the prototype be moved from include/drm/drm_gem.h to
drivers/gpu/drm/drm_internal.h?

Noralf.


>   /**
>    * drm_gem_handle_create_tail - internal functions to create a handle