[PATCH v4 2/2] staging: ion: create one device entry per heap

Laura Abbott labbott at redhat.com
Tue Sep 26 18:08:34 UTC 2017


On 09/26/2017 09:17 AM, Mark Brown wrote:
> On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote:
> 
>> version 4:
>> - add a configuration flag to switch between legacy Ion misc device
>>    and one device per heap version.
> 
> Should this be a switch or should it just be enabling and disabling the
> legacy device with the per heap ones always availalbe?  I can't see that
> the new devices would do any harm or have trouble interacting with the
> per heap ones.  Being able to have both enabled would make things easier
> for userspaces that are moving to the device per heap interface.
> 

Agreed. We should be enabling the new interface unconditionally. The
old /dev/ion interface should coexist to allow for backwards
compatibility but keep it under a Kconfig to allow it to be turned off
for security or other reasons.

Thanks,
Laura


More information about the dri-devel mailing list