[PATCH hwc v1] drm_hwcomposer: Add CONTRIBUTING file

Rob Herring robh at kernel.org
Wed Sep 27 21:16:43 UTC 2017


On Wed, Sep 27, 2017 at 1:55 PM, Robert Foss <robert.foss at collabora.com> wrote:
> Hey Emil,
>
> On Wed, 2017-09-27 at 15:42 +0100, Emil Velikov wrote:
>> Hi Rob,
>>
>> Glad to see this. There's a couple of suggestions that I hope you'll
>> find worth while.
>>
>> On 22 September 2017 at 01:37, Robert Foss <robert.foss at collabora.com
>> > wrote:
>> > Some basic guidelines for contributions could come in handy.
>> >
>> > These are copied from IGT and modified to be suitable.
>> >
>> > Signed-off-by: Robert Foss <robert.foss at collabora.com>
>> > ---
>> >  CONTRIBUTING | 31 +++++++++++++++++++++++++++++++
>> >  1 file changed, 31 insertions(+)
>> >  create mode 100644 CONTRIBUTING
>> >
>> > diff --git a/CONTRIBUTING b/CONTRIBUTING
>> > new file mode 100644
>> > index 0000000..f1b4775
>> > --- /dev/null
>> > +++ b/CONTRIBUTING
>> > @@ -0,0 +1,31 @@
>> > +Patches to drm_hwcomposer are very much welcome, we really want
>> > this to be the
>> > +universal HW composer implementation for Android and similar
>> > platforms
>> > +So please bring on porting patches, bugfixes, improvements for
>> > documentation
>> > +and new features.
>> > +
>> > +A short list of contribution guidelines:
>> > +
>> > +- Please submit patches formatted with git send-email/git format-
>> > patch or
>> > +  equivalent to
>> > +
>> > +    dri-devel <dri-devel at lists.freedesktop.org>
>> > +
>> > +  Please use --subject-prefix="PATCH hwc" so that drm_hwcomposer
>> > patches are easily
>> > +  identified in the massive amount mails on dri-devel. To ensure
>> > this is always
>> > +  done, run:
>> > +
>> > +    git config format.subjectprefix "PATCH hwc"
>> > +
>>
>> One can add this into the autogen.sh or whatever bootstrap file the
>> project uses.
>> For example see https://cgit.freedesktop.org/mesa/drm/tree/autogen.sh
>
> Adding an autogen.sh sounds like a good idea to me.

Except autogen.sh is a standard step as part of an autotools workflow
and would not be obvious to run in an Android env.

Rob


More information about the dri-devel mailing list