[PATCH v2 0/3] drm/tinydrm: drm_of_find_backlight helper
Daniel Vetter
daniel at ffwll.ch
Thu Sep 28 07:19:50 UTC 2017
On Thu, Sep 28, 2017 at 11:31:37AM +0530, Meghana Madhyastha wrote:
> This patchset introduces some changes such as move
> tinydrm_of_find_backlight to drm_of.c and rename it to
> drm_of_find_backlight for better organizational structure.
>
> Changes in v2:
> -Broke the patch into a patchset of 3 patches
> -Added devres versions of drm_of_find_backlight
> -Added a note about caller having to call put_device
Sorry for making you respin this once more, but the split-up here doesn't
make sense. After patch 1 tinydrm doesn't compile anymore (since it still
uses tinydrm_of_find_backlight, but that's removed already). I've also
made a few other comments on v1 of your series.
-Daniel
>
> Meghana Madhyastha (3):
> drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c
> drm/tinydrm: Call drm_of_find_backlight instead of
> tinydrm_of_find_backlight
> drm/tinydrm: Add devres versions of drm_of_find_backlight
>
> drivers/gpu/drm/drm_of.c | 44 ++++++++++++++++++++++++++
> drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 -----------------------
> drivers/gpu/drm/tinydrm/mi0283qt.c | 3 +-
> include/drm/drm_of.h | 3 ++
> include/drm/tinydrm/tinydrm-helpers.h | 1 -
> 5 files changed, 49 insertions(+), 42 deletions(-)
>
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list