[RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

Robert Foss robert.foss at collabora.com
Tue Apr 3 08:22:22 UTC 2018


Hey Chih-Wei,

Thanks for the poke, the patch has been pushed now.


Rob.

On 04/03/2018 04:58 AM, Chih-Wei Huang wrote:
> 2018-03-28 23:22 GMT+08:00 Rob Herring <robh at kernel.org>:
>> On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring <robh at kernel.org> wrote:
>>> On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake <stschake at gmail.com> wrote:
>>>> Hey John,
>>>>
>>>> On Fri, Mar 16, 2018 at 10:48 PM, John Stultz <john.stultz at linaro.org> wrote:
>>>>> In trying to integrate the new gralloc_handle.h with the
>>>>> drm_hwcomposer, I started seeing the following compilation
>>>>> errors:
>>>>>
>>>>> In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28:
>>>>> external/libdrm/android/gralloc_handle.h:108:9: error: cannot initialize return object of type 'native_handle_t *' (aka 'native_handle *') with an lvalue of type 'struct gralloc_handle_t *'
>>>>>          return handle;
>>>>>                 ^~~~~~
>>>>> 1 error generated.
>>>
>>> Somehow this is not throwing an error for me...
>>
>> NM. I have it fixed in a subsequent change in my tree...
> 
> Hi,
> I saw the same error after updated to libdrm master branch.
> Could John's fix be merged?
> Or maybe Rob has a better fix?
> 
> 


More information about the dri-devel mailing list