[PATCH 1/3] drm/omap: fix uninitialized ret variable

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Thursday, 29 March 2018 13:40:36 EEST Tomi Valkeinen wrote:
> audio_config function for both HDMI4 and HDMI5 return uninitialized
> value as the error code if the display is not currently enabled. For
> some reason this has not caused any issues.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

I wonder why the compiler hasn't caught this before.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/hdmi4.c | 2 +-
>  drivers/gpu/drm/omapdrm/dss/hdmi5.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index 97c88861d67a..5879f45f6fc9
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> @@ -679,7 +679,7 @@ static int hdmi_audio_config(struct device *dev,
>  			     struct omap_dss_audio *dss_audio)
>  {
>  	struct omap_hdmi *hd = dev_get_drvdata(dev);
> -	int ret;
> +	int ret = 0;
> 
>  	mutex_lock(&hd->lock);
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index d28da9ac3e90..ae1a001d1b83
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> @@ -671,7 +671,7 @@ static int hdmi_audio_config(struct device *dev,
>  			     struct omap_dss_audio *dss_audio)
>  {
>  	struct omap_hdmi *hd = dev_get_drvdata(dev);
> -	int ret;
> +	int ret = 0;
> 
>  	mutex_lock(&hd->lock);


-- 
Regards,

Laurent Pinchart