[PATCH v2] drm/msm: don't deref error pointer in the msm_fbdev_create error path

Emil Velikov emil.l.velikov at gmail.com
Tue Apr 3 15:15:12 UTC 2018


On 28 March 2018 at 17:22, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Currently the error pointer returned by msm_alloc_stolen_fb gets passed
> to drm_framebuffer_remove. The latter handles only NULL pointers, thus
> a nasty crash will occur.
>
> Drop the unnecessary fail label and the associated checks - both err and
> fb will be set at this stage.
>
> Cc: Rob Clark <robdclark at gmail.com>
> Cc: linux-arm-msm at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Cc: freedreno at lists.freedesktop.org
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> v2: really remove the fail label :-\
> ---

Humble ping?

-Emil


More information about the dri-devel mailing list