[PATCH libdrm] etnaviv: remove never-implemented etna_bo_from_handle()

[Christian Gmeiner]

2018-04-04 17:33 GMT+02:00 Eric Engestrom <eric.engestrom at imgtec.com>:
> Entrypoint has been listed since the etnaviv support was added, but was
> never implemented, and therefore never exported either.
>
> Fixes: 95e2cc6a801d92a0634b "libdrm: add etnaviv drm support"
> Cc: Christian Gmeiner <christian.gmeiner at gmail.com>
> Cc: Lucas Stach <l.stach at pengutronix.de>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
> Christian, Lucas: if you prefer, you could also implement it (please cc me),
> but since it's never been implemented, I expect no driver needs it.
> ---
>  etnaviv/etnaviv-symbol-check | 1 -
>  etnaviv/etnaviv_drmif.h      | 2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/etnaviv/etnaviv-symbol-check b/etnaviv/etnaviv-symbol-check
> index bc50961590870f4cf3d4..b1598ce52838c847096a 100755
> --- a/etnaviv/etnaviv-symbol-check
> +++ b/etnaviv/etnaviv-symbol-check
> @@ -23,7 +23,6 @@ etna_pipe_del
>  etna_pipe_wait
>  etna_pipe_wait_ns
>  etna_bo_new
> -etna_bo_from_handle
>  etna_bo_from_name
>  etna_bo_from_dmabuf
>  etna_bo_ref
> diff --git a/etnaviv/etnaviv_drmif.h b/etnaviv/etnaviv_drmif.h
> index 5a6bef8d12d1bce40fb4..80aedc1cfc971afcae98 100644
> --- a/etnaviv/etnaviv_drmif.h
> +++ b/etnaviv/etnaviv_drmif.h
> @@ -115,8 +115,6 @@ int etna_pipe_wait_ns(struct etna_pipe *pipe, uint32_t timestamp, uint64_t ns);
>
>  struct etna_bo *etna_bo_new(struct etna_device *dev,
>                 uint32_t size, uint32_t flags);
> -struct etna_bo *etna_bo_from_handle(struct etna_device *dev,
> -               uint32_t handle, uint32_t size);
>  struct etna_bo *etna_bo_from_name(struct etna_device *dev, uint32_t name);
>  struct etna_bo *etna_bo_from_dmabuf(struct etna_device *dev, int fd);
>  struct etna_bo *etna_bo_ref(struct etna_bo *bo);
> --
> Cheers,
>   Eric
>



-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info