[PATCH libdrm v2 14/23] meson: use simple option handling for omap

Eric Engestrom eric.engestrom at imgtec.com
Thu Apr 5 10:12:37 UTC 2018


On Wednesday, 2018-04-04 19:55:18 +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Apr 04, 2018 at 04:38:09PM +0100, Eric Engestrom wrote:
> > [...]
> >
> > -with_omap = false
> > -_omap = get_option('omap')
> > -if _omap == 'true'
> > -  if not with_atomics
> > -    error('libdrm_omap requires atomics.')
> > -  endif
> > -  with_omap = true
> > +with_exynos = false
> > +_exynos = get_option('exynos')
> > +if _exynos == 'auto'
> > +  with_exynos = true
> > +else
> > +  with_exynos = _exynos == 'true'
> >  endif
> 
> Looks like some patch rebasing went wrong with this one (it
> simplifies omap, but also adds some exynos stuff)?

Indeed, that's a complete rebase fail...
Thanks for not letting me push this unaware :)

I'll send a v3 of 8-19 next week, after landing the first bits (1-7).
I think I'll defer 20-23 to after everything else has landed.

> 
> -- Sebastian


More information about the dri-devel mailing list