[PATCH 07/10] drm/msm/adreno: Convert the show/crash file format

Chris Wilson chris at chris-wilson.co.uk
Fri Apr 6 11:00:23 UTC 2018


Quoting Jordan Crouse (2018-04-05 23:00:53)
> Convert the format of the 'show' debugfs file and the crash
> dump to a  format resembling YAML. This should be easier to
> parse and be more flexible for future changes and expansions.
> 
> Signed-off-by: Jordan Crouse <jcrouse at codeaurora.org>

+1, I've been trying to work up the courage to make the conversion to
yaml for i915 as well.

My gut feeling says we at least want to move the indentation handling to
drm_print.

>         for (i = 0; i < state->nr_registers; i++) {
> -               drm_printf(p, "IO:R %08x %08x\n",
> +               drm_printf(p, "  - [0x%04x, 0x%08x]\n",

Hmm, sequence of sequences. The alternative would be
   - {offset:%x, value:%x}

May I ask why you would pick one over the other?

I like the verbosity of having the nodes, it should also mean that the
order is immaterial and we could extend it with say name:, comments: or
whatever, without affecting the parser.

Otoh, the [] are more compact.
-Chris


More information about the dri-devel mailing list