[PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
kbuild test robot
lkp at intel.com
Fri Apr 6 11:46:17 UTC 2018
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048
base: git://linuxtv.org/media_tree.git master
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips
All warnings (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/dss/dispc.c: In function 'pixinc':
>> drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1861:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
return 0;
^~~~~~
vim +/else +1859 drivers/video/fbdev/omap2/omapfb/dss/dispc.c
f76ee892 Tomi Valkeinen 2015-12-09 1850
f76ee892 Tomi Valkeinen 2015-12-09 1851 static s32 pixinc(int pixels, u8 ps)
f76ee892 Tomi Valkeinen 2015-12-09 1852 {
f76ee892 Tomi Valkeinen 2015-12-09 1853 if (pixels == 1)
f76ee892 Tomi Valkeinen 2015-12-09 1854 return 1;
f76ee892 Tomi Valkeinen 2015-12-09 1855 else if (pixels > 1)
f76ee892 Tomi Valkeinen 2015-12-09 1856 return 1 + (pixels - 1) * ps;
f76ee892 Tomi Valkeinen 2015-12-09 1857 else if (pixels < 0)
f76ee892 Tomi Valkeinen 2015-12-09 1858 return 1 - (-pixels + 1) * ps;
f76ee892 Tomi Valkeinen 2015-12-09 @1859 else
f76ee892 Tomi Valkeinen 2015-12-09 1860 BUG();
f76ee892 Tomi Valkeinen 2015-12-09 1861 return 0;
f76ee892 Tomi Valkeinen 2015-12-09 1862 }
f76ee892 Tomi Valkeinen 2015-12-09 1863
:::::: The code at line 1859 was first introduced by commit
:::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
:::::: TO: Tomi Valkeinen <tomi.valkeinen at ti.com>
:::::: CC: Tomi Valkeinen <tomi.valkeinen at ti.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 55128 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180406/f1034171/attachment-0001.gz>
More information about the dri-devel
mailing list