[PATCH 7/9] drm/gem-fb-helper: Always do implicit sync

Eric Anholt eric at anholt.net
Fri Apr 20 22:11:24 UTC 2018


Daniel Vetter <daniel.vetter at ffwll.ch> writes:

> I've done a lot of history digging. The first signs of this
> optimization was introduced in i915:

I can't come up with any reason this would matter.  I almost came up
with "You're doing tearing X11 front buffer rendering, and you do a
modeset using the same fb, and so you block that modeset behind your
rendering."  Except that:

1) who cares
2) this helper is only for dma-bufs, not normal X11 rendering
3) your X11 driver should be doing pageflipping to be tear-free anyway,
   let's just fix that[1].

Reviewed-by: Eric Anholt <eric at anholt.net>

[1] This is not actually me volunteering myself or anyone else to go fix
that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180420/87447203/attachment.sig>


More information about the dri-devel mailing list