[PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Andrey Grodzovsky Andrey.Grodzovsky at amd.com
Wed Apr 25 16:13:58 UTC 2018



On 04/25/2018 11:29 AM, Eric W. Biederman wrote:
>> Another issue is changing wait_event_killable to wait_event_timeout where I need
>> to understand
>> what TO value is acceptable for all the drivers using the scheduler, or maybe it
>> should come as a property
>> of drm_sched_entity.
> It would not surprise me if you could pick a large value like 1 second
> and issue a warning if that time outever triggers.  It sounds like the
> condition where we wait indefinitely today is because something went
> wrong in the driver.

We wait here for all GPU jobs in flight which belong to the dying entity 
to complete. The driver submits
the GPU jobs but the content of the job might be is not under driver's 
control and could take
long time to finish or even hang (e.g. graphic or compute shader) , I 
guess that why originally the wait is indefinite.

Andrey

>
> Eric

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180425/dd21aaf0/attachment.html>


More information about the dri-devel mailing list