[radeon-alex:drm-next-4.18-wip 201/261] drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:194 pp_late_init() error: we previously assumed 'hwmgr' could be null (see line 185)

[Dan Carpenter]

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-4.18-wip
head:   92fb37464bd2b759d74f33c3b90a27575601745d
commit: cb2bd409128cdf4b6ac7779e55876956271be9f3 [201/261] drm/amd/powerplay: add control gfxoff enabling in late init

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:194 pp_late_init() error: we previously assumed 'hwmgr' could be null (see line 185)

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout cb2bd409128cdf4b6ac7779e55876956271be9f3
vim +/hwmgr +194 drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c

7bdb3db41 Rex Zhu   2018-04-13  178  
6d07fe7bc Rex Zhu   2017-09-25  179  static int pp_late_init(void *handle)
6d07fe7bc Rex Zhu   2017-09-25  180  {
b905090d2 Rex Zhu   2018-03-12  181  	struct amdgpu_device *adev = handle;
b905090d2 Rex Zhu   2018-03-12  182  	struct pp_hwmgr *hwmgr = adev->powerplay.pp_handle;
cb2bd4091 Huang Rui 2018-03-13  183  	int ret;
6d07fe7bc Rex Zhu   2017-09-25  184  
b61e54cb1 Rex Zhu   2018-03-22 @185  	if (hwmgr && hwmgr->pm_en) {
b61e54cb1 Rex Zhu   2018-03-22  186  		mutex_lock(&hwmgr->smu_lock);
b61e54cb1 Rex Zhu   2018-03-22  187  		hwmgr_handle_task(hwmgr,
39199b803 Evan Quan 2017-12-29  188  					AMD_PP_TASK_COMPLETE_INIT, NULL);
b61e54cb1 Rex Zhu   2018-03-22  189  		mutex_unlock(&hwmgr->smu_lock);
b61e54cb1 Rex Zhu   2018-03-22  190  	}
7bdb3db41 Rex Zhu   2018-04-13  191  	if (adev->pm.smu_prv_buffer_size != 0)
7bdb3db41 Rex Zhu   2018-04-13  192  		pp_reserve_vram_for_smu(adev);
cb2bd4091 Huang Rui 2018-03-13  193  
cb2bd4091 Huang Rui 2018-03-13 @194  	if (hwmgr->hwmgr_func->gfx_off_control &&
cb2bd4091 Huang Rui 2018-03-13  195  	    (hwmgr->feature_mask & PP_GFXOFF_MASK)) {
cb2bd4091 Huang Rui 2018-03-13  196  		ret = hwmgr->hwmgr_func->gfx_off_control(hwmgr, true);
cb2bd4091 Huang Rui 2018-03-13  197  		if (ret)
cb2bd4091 Huang Rui 2018-03-13  198  			pr_err("gfx off enabling failed!\n");
cb2bd4091 Huang Rui 2018-03-13  199  	}
cb2bd4091 Huang Rui 2018-03-13  200  
6d07fe7bc Rex Zhu   2017-09-25  201  	return 0;
6d07fe7bc Rex Zhu   2017-09-25  202  }
6d07fe7bc Rex Zhu   2017-09-25  203  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation