[PATCH] drm: omapdrm: displays: fix port_num for opa362 output

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Aug 19 14:07:34 UTC 2018


Hi Nikolaus,

Thank you for the patch.

On Friday, 27 July 2018 17:24:32 EEST H. Nikolaus Schaller wrote:
> The opa362 amplifier has two ports, an input (usually connected
> to the OMAP3 VENC) and an output port connected to the external
> connector.
> 
> These are usually defined as input port at 0 and outpt port at 1 in
> the DT and really distinguished by the reg = <port_num> property
> of these nodes.
> 
> But we are missing to define the output port as number 1 so
> it does not match the DT entry.
> 
> Signed-off-by: H. Nikolaus Schaller <hns at goldelico.com>

I think this patch is superseded by "[PATCH v3 36/61] drm/omap: dss: Replace 
omap_dss_device port number with bitmask" which should get merged in v4.20.

> ---
>  drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index
> afee1b8b457a..296d46f060b2 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> @@ -208,6 +208,7 @@ static int opa362_probe(struct platform_device *pdev)
>  	dssdev->type = OMAP_DISPLAY_TYPE_VENC;
>  	dssdev->output_type = OMAP_DISPLAY_TYPE_VENC;
>  	dssdev->owner = THIS_MODULE;
> +	dssdev->port_num = 1;	/* second port */
> 
>  	r = omapdss_register_output(dssdev);
>  	if (r) {

-- 
Regards,

Laurent Pinchart





More information about the dri-devel mailing list