[PATCH] drm/ttm: Initialize local lists in ttm_bo_bulk_move_helper

Christian König ckoenig.leichtzumerken at gmail.com
Wed Aug 29 07:13:56 UTC 2018


Am 28.08.2018 um 18:58 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> The first parameter of list_cut_position() must point to an initialized
> list.
>
> Noticed thanks to KASAN pointing out something's fishy here.
>
> Fixes: "drm/ttm: add bulk move function on LRU"
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 39d9d559b279..35d53d81f486 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -250,7 +250,8 @@ EXPORT_SYMBOL(ttm_bo_move_to_lru_tail);
>   static void ttm_bo_bulk_move_helper(struct ttm_lru_bulk_move_pos *pos,
>   				    struct list_head *lru, bool is_swap)
>   {
> -	struct list_head entries, before;
> +	LIST_HEAD(entries);
> +	LIST_HEAD(before);
>   	struct list_head *list1, *list2;
>   
>   	list1 = is_swap ? &pos->last->swap : &pos->last->lru;



More information about the dri-devel mailing list