[PATCH] drm/bochs: Replace ttm_bo_unref with ttm_bo_put

Thomas Zimmermann tzimmermann at suse.de
Thu Aug 30 06:14:02 UTC 2018


Hi Gerd

Am 09.08.2018 um 17:27 schrieb Gerd Hoffmann:
>> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
>> index 39cd08416773..c9c7097030ca 100644
>> --- a/drivers/gpu/drm/bochs/bochs_mm.c
>> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
>> @@ -430,7 +430,7 @@ static void bochs_bo_unref(struct bochs_bo **bo)
>>  		return;
>>  
>>  	tbo = &((*bo)->bo);
>> -	ttm_bo_unref(&tbo);
>> +	ttm_bo_put(tbo);
> 
> fails to build:
> 
>   CC [M]  drivers/gpu/drm/bochs/bochs_mm.o
> /home/kraxel/projects/linux/drivers/gpu/drm/bochs/bochs_mm.c: In function ‘bochs_bo_unref’:
> /home/kraxel/projects/linux/drivers/gpu/drm/bochs/bochs_mm.c:433:2: error: implicit declaration of function ‘ttm_bo_put’ [-Werror=implicit-function-declaration]
>   ttm_bo_put(tbo);
>   ^
> cc1: some warnings being treated as errors

The required interfaces are now available in mainline. [1] I rebuilt to
make sure it compiles.

Besides bochs, [2] the patches for qxl, [3] cirrus, [4] vmwgfx, [5][6]
and virtio [7][8] should now build as well. They still apply cleanly
AFAICT. Let me know if you prefer a new patch set instead.

Best regards
Thomas

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=89c815ef07a1db0ac2cc09d06cb2d5c3d86d6322
[2] https://patchwork.freedesktop.org/patch/241728/
[3] https://patchwork.freedesktop.org/patch/241732/
[4] https://patchwork.freedesktop.org/patch/241729/
[5] https://patchwork.freedesktop.org/patch/241726/
[6] https://patchwork.freedesktop.org/patch/241727/
[7] https://patchwork.freedesktop.org/patch/241724/
[8] https://patchwork.freedesktop.org/patch/241725/


> cheers,
>   Gerd
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20180830/127b7567/attachment.sig>


More information about the dri-devel mailing list