[PATCH] drm/amdgpu/acpi: NULL check before some freeing functions is not needed

Lyude Paul lyude at redhat.com
Wed Dec 5 19:02:15 UTC 2018


Reviewed-by: Lyude Paul <lyude at redhat.com>

Thanks!

On Wed, 2018-12-05 at 15:43 +0800, Wen Yang wrote:
> kfree(NULL) is safe, so removes NULL check before freeing the mem.
> This patch also fix the ifnullfree.cocci warnings.
> 
> Signed-off-by: Wen Yang <wen.yang99 at zte.com.cn>
> CC: Alex Deucher <alexander.deucher at amd.com>
> CC: christian.koenig at amd.com
> CC: "David (ChunMing) Zhou" <David1.Zhou at amd.com>
> CC: David Airlie <airlied at linux.ie> (maintainer:DRM DRIVERS)
> CC: Lyude Paul <lyude at redhat.com>
> CC: Rex Zhu <Rex.Zhu at amd.com>
> CC: Jim Qu <Jim.Qu at amd.com>
> CC: amd-gfx at lists.freedesktop.org
> CC: dri-devel at lists.freedesktop.org
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> index 7f0afc526419..996bfce149f2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> @@ -816,6 +816,5 @@ int amdgpu_acpi_init(struct amdgpu_device *adev)
>  void amdgpu_acpi_fini(struct amdgpu_device *adev)
>  {
>  	unregister_acpi_notifier(&adev->acpi_nb);
> -	if (adev->atif)
> -		kfree(adev->atif);
> +	kfree(adev->atif);
>  }
-- 
Cheers,
	Lyude Paul



More information about the dri-devel mailing list